Preserve incoming intent extras as-is for orcherstrator#1544
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where intent extras were prematurely converted to strings, causing the LibSimprints version parameter to lose its type information. The fix preserves the original types of intent extras for the orchestrator while ensuring string conversion only happens when reporting invalid intent events.
Changes:
- Removed premature string conversion of intent extras to preserve type information (e.g., Int values remain as Int)
- Moved string conversion to only occur when reporting invalid intent events
- Added test to verify that type information (specifically contractVersion as Int) is properly preserved
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| feature/client-api/src/main/java/com/simprints/feature/clientapi/ClientApiViewModel.kt | Removed premature .mapValues { it.value.toString() } conversion and moved it to the error handling path only |
| feature/client-api/src/test/java/com/simprints/feature/clientapi/ClientApiViewModelTest.kt | Added test case to verify contractVersion Int type is preserved through intent handling |
ca6d4bc to
7ce9d4c
Compare
|
meladRaouf
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Will be released in: 2026.1.0
Root cause analysis (for bugfixes only)
First known affected version: 2026.1.0
Notable changes
Testing guidance
Additional work checklist