Handle a special case with a single artefact download#1546
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a special case in the GitHub Actions workflow where downloading a single test artifact behaves differently than downloading multiple artifacts. When a single artifact is downloaded, it's automatically unpacked into the destination folder rather than into a subfolder, causing the subsequent report collection step to fail.
Changes:
- Replaced hardcoded module-specific rsync commands with a dynamic loop-based approach
- Added fallback logic to handle the single artifact case by copying from test-reports root when no subfolders exist
- Enhanced error handling with bash strict mode and nullglob option
| ALL_SKIPPED=false | ||
|
|
||
| # Copy the contents of each artifact folder into the workspace root | ||
| rsync -arv "${ARTIFACT_DIR}" . || true |
There was a problem hiding this comment.
The rsync command is copying the artifact directory itself rather than its contents. This will create subdirectories in the workspace root (e.g., 'core/', 'infra1/') instead of copying the contents directly to the root as intended. To copy only the contents, append a trailing slash to the source path.
| rsync -arv "${ARTIFACT_DIR}" . || true | |
| rsync -arv "${ARTIFACT_DIR}/" . || true |
There was a problem hiding this comment.
This is intended behaviour.
f31b3eb to
b818f21
Compare
|



Will be released in: 2026.1.0
Root cause analysis (for bugfixes only)
Notable changes
Testing guidance
Additional work checklist