[MS-1341] Adding on tap focus for the OCR scanner#1581
Merged
Conversation
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
Copilot,
luhmirin-s and
meladRaouf
There was a problem hiding this comment.
Pull request overview
Adds CameraX focus controls to the external credential OCR scanning screen, enabling tap-to-focus (and initial autofocus) to improve OCR capture reliability in the MFID workflow.
Changes:
- Extend
ProvideCameraListenerUseCaseto return the boundCamerainstance via a new callback. - Wire
CameraFocusManagerintoExternalCredentialScanOcrFragmentto set up tap-to-focus and autofocus on the preview.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/usecase/ProvideCameraListenerUseCase.kt | Exposes the bound Camera instance to callers via onCameraReady. |
| feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt | Initializes focus controls on the camera preview using CameraFocusManager once the Camera is available. |
|
luhmirin-s
approved these changes
Feb 11, 2026
meladRaouf
pushed a commit
that referenced
this pull request
Mar 3, 2026
* [MS-1341] Adding on tap focus for the OCR scanner * [MS-1341] Removing 'camera' field and verifying lifecycle state before using binding (cherry picked from commit 9c1e017)
meladRaouf
pushed a commit
that referenced
this pull request
Mar 3, 2026
* [MS-1341] Adding on tap focus for the OCR scanner * [MS-1341] Removing 'camera' field and verifying lifecycle state before using binding (cherry picked from commit 9c1e017)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.1
Notable changes
Autofocus on tap is added to the OCR screen in the MFID workflow
Testing guidance
Additional work checklist