[MS-1338] MFID: removing the post-match confirmation checkbox#1582
Merged
alexandr-simprints merged 2 commits intoFeb 12, 2026
Conversation
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
Copilot,
luhmirin-s and
meladRaouf
There was a problem hiding this comment.
Pull request overview
This PR removes the credential confirmation checkbox from the ScannedCredentialDialog, which is displayed during post-match identity confirmation flows. Previously, users had to check a confirmation checkbox before the "Add" button was enabled. Now, the button is enabled by default, simplifying the user experience.
Changes:
- Removed the confirmation checkbox from the scanned credential dialog UI
- Enabled the confirm button by default (removed
android:enabled="false") - Added ktlint configuration rules (unrelated to the main change)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| feature/external-credential/src/main/res/layout/dialog_scanned_credential.xml | Removed checkbox element, added separator divider, adjusted margins, and enabled the confirm button by default |
| feature/external-credential/src/main/java/com/simprints/feature/externalcredential/view/ScannedCredentialDialog.kt | Removed checkbox initialization and click listener code |
| .editorconfig | Added ktlint rules for when-entry-bracing, blank-line-between-when-conditions, backticked identifiers, and unused imports (unrelated to checkbox removal) |
|
luhmirin-s
approved these changes
Feb 11, 2026
alexandr-simprints
deleted the
MS-1338-mfid-removing-the-post-match-confirmation-checkbox
branch
meladRaouf
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Cherry picking latest linter rulesˆ from the main branch * [MS-1338] Removing checkbox from the credential confirmation (cherry picked from commit 376ca5d)
meladRaouf
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Cherry picking latest linter rulesˆ from the main branch * [MS-1338] Removing checkbox from the credential confirmation (cherry picked from commit 376ca5d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.1
Notable changes
Testing guidance
Additional work checklist