Skip to content

Bugfix/negative face area #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meladRaouf wants to merge 2 commits into from
Closed

Bugfix/negative face area #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
500adc3
[MS-1412] Fix area calculation in RectF to handle negative values
meladRaouf Apr 21, 2026
8dddc5c
[MS-1413] Enhance face area detection logic to adapt based on image size
meladRaouf Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion face/capture/src/main/java/com/simprints/face/capture/models/FaceTarget.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import kotlin.math.abs
internal data class FaceTarget(
val yawTarget: Target,
val rollTarget: Target,
val areaRange: ClosedRange<Float>,
val minFacePixelArea: Float,
val maxRelativeArea: Float,
) {
operator fun contains(face: Face): Boolean = face.roll in rollTarget && face.yaw in yawTarget
}
Expand Down
16 changes: 13 additions & 3 deletions ...ain/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragmentViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ internal class LiveFeedbackFragmentViewModel @Inject constructor(
private val faceTarget = FaceTarget(
SymmetricTarget(VALID_YAW_DELTA),
SymmetricTarget(VALID_ROLL_DELTA),
0.20f..0.5f,
minFacePixelArea = 10000f, // Todo to be visited latter
maxRelativeArea = 0.5f,
)
private val fallbackCaptureEventStartTime = timeHelper.now()
private var shouldSendFallbackCaptureEvent: AtomicBoolean = AtomicBoolean(true)
Expand Down Expand Up @@ -229,9 +230,18 @@ internal class LiveFeedbackFragmentViewModel @Inject constructor(
potentialFace: Face,
): FaceDetection {
val areaOccupied = potentialFace.relativeBoundingBox.area()

// 2. Calculate the absolute pixel area the face occupies in the current bitmap
val totalImageArea = bitmap.width * bitmap.height
val absoluteFaceArea = areaOccupied * totalImageArea

val status = when {
areaOccupied < faceTarget.areaRange.start -> FaceDetection.Status.TOOFAR
areaOccupied > faceTarget.areaRange.endInclusive -> FaceDetection.Status.TOOCLOSE
// Check if the face lacks enough pixel density (TOOFAR)
absoluteFaceArea < faceTarget.minFacePixelArea -> FaceDetection.Status.TOOFAR

// Check if the face is overflowing the camera frame (TOOCLOSE)
areaOccupied > faceTarget.maxRelativeArea -> FaceDetection.Status.TOOCLOSE

potentialFace.yaw !in faceTarget.yawTarget -> FaceDetection.Status.OFFYAW
potentialFace.roll !in faceTarget.rollTarget -> FaceDetection.Status.OFFROLL
shouldCheckQuality() && potentialFace.quality < qualityThreshold -> FaceDetection.Status.BAD_QUALITY
Expand Down
3 changes: 2 additions & 1 deletion infra/core/src/main/java/com/simprints/core/tools/extentions/RectF.ext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.simprints.core.tools.extentions

import android.graphics.RectF
import kotlin.math.abs

fun RectF.area() = height() * width()
fun RectF.area() = abs(height() * width())
Loading