[MS-220] Moving loading state indication to a separate LiveData field#575
Merged
alexandr-simprints merged 1 commit intoFeb 26, 2024
Conversation
… within LoginFormViewModel, and observing it from LoginFormFragment
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
|
luhmirin-s
approved these changes
Feb 22, 2024
meladRaouf
approved these changes
Feb 25, 2024
alexandr-simprints
deleted the
MS-220-login-screen-authentication-process-is-cancelled-on-rotation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the loading state indicator on the Login fragment to its View Model. This way the correct loading indication is displayed after the device is rotated.