[MS-418] Don't include projectConfigurationUpdatedAt if it's empty#683
Merged
BurningAXE merged 1 commit intoApr 22, 2024
Conversation
BurningAXE
requested review from
a team,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
approved these changes
Apr 18, 2024
ybourgery
requested changes
Apr 18, 2024
| val device: ApiDevice, | ||
| val databaseInfo: ApiDatabaseInfo, | ||
| val location: ApiLocation?, | ||
| @JsonInclude(Include.NON_EMPTY) |
Collaborator
There was a problem hiding this comment.
I think you could add a test to ensure that you have what you want, and if people remove the annotation something will fail
Contributor
Author
There was a problem hiding this comment.
Good idea! Added a test.
BurningAXE
force-pushed
the
MS-418-projectConfigurationUpdatedAt-should-not-be-sent-if-it-s-empty
branch
from
af54461 to
8ae336f
Compare
ybourgery
approved these changes
Apr 18, 2024
|
alexandr-simprints
approved these changes
Apr 22, 2024
luhmirin-s
deleted the
MS-418-projectConfigurationUpdatedAt-should-not-be-sent-if-it-s-empty
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info in the ticket. Opting for the much simpler solution to avoid more work and potential problems arising from changing the type of the field.