MS-427 Add request ID to response headers locally#691
Merged
luhmirin-s merged 1 commit intoApr 22, 2024
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
ethiery,
meladRaouf and
ybourgery
and removed request for
a team
|
alexandr-simprints
approved these changes
Apr 22, 2024
ethiery
reviewed
Apr 22, 2024
| // Adding same header to both request and response to | ||
| // track the request across network logs and analytics events. | ||
| val newRequest = chain.request().newBuilder().addHeader(REQUEST_ID_HEADER, requestId).build() | ||
| return@Interceptor chain.proceed(newRequest).newBuilder().addHeader(REQUEST_ID_HEADER, requestId).build() |
Contributor
Author
There was a problem hiding this comment.
Not really, but this works. :D IMO, this is a bit of misuse, since the client should not add the response data 🤷🏻
Collaborator
There was a problem hiding this comment.
Agreed, but as far as hacks go, this is probably the smallest possible change you could make to make this work 😂 Code golf winner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.