Save & restore OrchestratorViewModel's data in case of Activity kill & restore#709
Merged
BurningAXE merged 3 commits intoMay 8, 2024
Conversation
BurningAXE
requested review from
a team,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
approved these changes
May 8, 2024
…ity was killed and restored
BurningAXE
force-pushed
the
MS-437-Gavi-Ghana-Well-Labeled-Data-Set-GG-WLDS-Collection-Investigation
branch
from
d0aad66 to
c0d196d
Compare
|
luhmirin-s
deleted the
MS-437-Gavi-Ghana-Well-Labeled-Data-Set-GG-WLDS-Collection-Investigation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial problem was this crash that was caused by the Path class not being Serializable.
However, after fixing that I found out that when OrchestratorActivity is killed, the VM is killed, too. In the VM's onCleared() we save the steps but we never load them when Activity/Fragment is restored.
Fixing the above uncovered that we also need to restore the modalities, too.
Fixing the above uncovered that ActionRequest is not properly deserialized because it lacks subtype info.
IMO, we can improve the VM saving & restoration by unifying the current 3 separate calls. However, I did not want to do too much refactoring at this point in the release. I'll create a ticket to consider and fix this in the next release.