MS-338 New image saving strategy#718
Merged
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
meladRaouf
approved these changes
May 15, 2024
ybourgery
requested changes
May 15, 2024
Collaborator
ybourgery
left a comment
ybourgery
left a comment
There was a problem hiding this comment.
You need to add the ONLY_USED_IN_REFERENCE for face too (it would be the same as the current implementation of ONLY_GOOD_SCANS)
Contributor
Author
🤦🏻 For unknown reason I assumed that it uses the same enum. |
ybourgery
approved these changes
May 15, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
ONLY_GOOD_SCANsaving strategy replaced byONLY_USED_IN_REFERENCEsince it is how it already works.ONLY_GOOD_SCANto extract only images with quality scores over the threshold.