Skip to content

MS-219 ID pool validation#738

Merged
luhmirin-s merged 5 commits into
mainfrom
feature/MS-219-id-pool-validation
Jun 5, 2024
Merged

MS-219 ID pool validation#738
luhmirin-s merged 5 commits into
mainfrom
feature/MS-219-id-pool-validation

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

Notable changes:

  • Added a new step to the identification flow to validate the potential pool of candidates before capturing biometrics.
  • If the candidate pool is empty, several conditions are checked to determine the most useful error message. (the error message wording is not final and could be updated via Transifex)
  • If the data has not been synced for longer than "maxAge" configuration, the user will be presented with an option to sync and retry.

@cla-bot cla-bot Bot added the ... label May 30, 2024
@luhmirin-s luhmirin-s force-pushed the feature/MS-219-id-pool-validation branch 2 times, most recently from ebb4d03 to ae7ffed Compare May 30, 2024 13:35
@luhmirin-s luhmirin-s marked this pull request as ready for review May 30, 2024 14:06
@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team May 30, 2024 14:06
@luhmirin-s luhmirin-s force-pushed the feature/MS-219-id-pool-validation branch from ae7ffed to f81c100 Compare May 30, 2024 14:25
Copy link
Copy Markdown
Contributor

@alexandr-simprints alexandr-simprints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving overall, but please address some of the comments

Comment thread infra/resources/src/main/res/values/strings.xml
@luhmirin-s luhmirin-s force-pushed the feature/MS-219-id-pool-validation branch from f81c100 to 943f066 Compare June 4, 2024 09:35
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2024

@BurningAXE
Copy link
Copy Markdown
Contributor

If the data has not been synced for longer than "maxAge" configuration, the user will be presented with an option to sync and retry.
Can this be named something other than age to avoid confusion (and mixed search results) with subjectAge which is about to be introduced shortly.

@luhmirin-s
Copy link
Copy Markdown
Contributor Author

If the data has not been synced for longer than "maxAge" configuration, the user will be presented with an option to sync and retry.
Can this be named something other than age to avoid confusion (and mixed search results) with subjectAge which is about to be introduced shortly.

The name has been discussed and agreed with the cloud team. It will be properly documented to avoid confusion on BE/Vulcan side.

@luhmirin-s luhmirin-s merged commit 0f1578b into main Jun 5, 2024
@luhmirin-s luhmirin-s deleted the feature/MS-219-id-pool-validation branch June 5, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants