Skip to content

Remove a test since it doesn't add any value; #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meladRaouf merged 2 commits into from
Jun 27, 2024
Merged

Remove a test since it doesn't add any value; #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
376f352
remove unused tests
meladRaouf Jun 24, 2024
e50d4f4
Refactor AgeGroup isEmpty check to include endExclusive equals zero
meladRaouf Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/config-store/src/main/java/com/simprints/infra/config/store/models/AgeGroup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ data class AgeGroup(
val endExclusive: Int?,
) {
fun isEmpty(): Boolean =
startInclusive == 0 && endExclusive == null
startInclusive == 0 && (endExclusive == null || endExclusive == 0)
}
12 changes: 0 additions & 12 deletions ...c/test/java/com/simprints/infra/config/store/local/models/FingerprintConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,6 @@ class FingerprintConfigurationTest {
assertThat(it.value.toProto()).isEqualTo(it.key)
}
}
@Test
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how about the coverage :D

Copy link
Copy Markdown
Collaborator Author

@meladRaouf meladRaouf Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allowed age groups was already covered in other tests

fun `should map correctly the allowedAgeRange`() {
val mapping = mapOf(
ProtoFingerprintConfiguration.VeroGeneration.VERO_1 to FingerprintConfiguration.VeroGeneration.VERO_1,
ProtoFingerprintConfiguration.VeroGeneration.VERO_2 to FingerprintConfiguration.VeroGeneration.VERO_2,
)

mapping.forEach {
assertThat(it.key.toDomain()).isEqualTo(it.value)
assertThat(it.value.toProto()).isEqualTo(it.key)
}
}

@Test
fun `should map correctly the FingerComparisonStrategy enums`() {
Expand Down
0 ...models/ApiAgeGroupSelectionPayloadTest.kt → ...ote/models/ApiGuidSelectionPayloadTest.kt
View file
Open in desktop
File renamed without changes.