Skip to content

[MS-570] limit number of event Scopes #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meladRaouf merged 1 commit into from
Jul 9, 2024
Merged

[MS-570] limit number of event Scopes #798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion infra/events/src/main/java/com/simprints/infra/events/event/local/SessionScopeRoomDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.room.Insert
import androidx.room.OnConflictStrategy
import androidx.room.Query
import com.simprints.infra.events.event.domain.models.scope.EventScopeType
import com.simprints.infra.events.event.local.SessionScopeRoomDao.EventScopeConstants.CLOSED_SCOPES_LIMIT
import com.simprints.infra.events.event.local.models.DbEventScope

@Dao
Expand All @@ -13,7 +14,9 @@ internal interface SessionScopeRoomDao {
@Query("select * from DbEventScope where type = :type AND end_unixMs IS NULL order by start_unixMs desc")
suspend fun loadOpen(type: EventScopeType): List<DbEventScope>

@Query("select * from DbEventScope where type = :type AND end_unixMs IS NOT NULL order by start_unixMs desc")
// Work around for loading too many scopes which cause upsync workers get stuck
// To limit the number of scopes loaded, we only load the last 50 closed scopes
@Query("select * from DbEventScope where type = :type AND end_unixMs IS NOT NULL order by start_unixMs desc limit $CLOSED_SCOPES_LIMIT")
Comment thread
alexandr-simprints marked this conversation as resolved.
suspend fun loadClosed(type: EventScopeType): List<DbEventScope>

@Query("select * from DbEventScope where id = :scopeId order by start_unixMs desc limit 1")
Expand All @@ -30,4 +33,8 @@ internal interface SessionScopeRoomDao {

@Query("delete from DbEventScope")
suspend fun deleteAll()

object EventScopeConstants {
const val CLOSED_SCOPES_LIMIT = 50
}
}