[MS-572] EventDownSyncRequest/EventUpSyncRequest events error type changed to just class name#805
Merged
Merged
Conversation
ybourgery
reviewed
Jul 10, 2024
| // Track a case when event stream is closed due to a parser error, | ||
| // but the exception is handled gracefully and channel is closed correctly. | ||
| errorType = it.toString() | ||
| errorType = it.javaClass.simpleName |
Collaborator
There was a problem hiding this comment.
Maybe you can add a test to prevent regression if someone updates this code (and same for the EventUpSyncTask)
ybourgery
approved these changes
Jul 10, 2024
alex-vt
force-pushed
the
task/MS-572-event-sync-simple-error-type
branch
from
485c97a to
a6cf137
Compare
Contributor
|
We have already released a candidate for |
…ced just to throwable class name
alex-vt
force-pushed
the
task/MS-572-event-sync-simple-error-type
branch
from
a6cf137 to
544a55c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
errorTypeinEventDownSyncRequestEventandEventUpSyncRequestEventused to contain the stack trace, which was excessive for logging at the backend.