[MS-577] Fetching GUID for verification only when biometricDataSource is Simprints#807
Merged
alex-vt merged 3 commits intoJul 11, 2024
Conversation
alexandr-simprints
approved these changes
Jul 11, 2024
BurningAXE
reviewed
Jul 11, 2024
| value = biometricDataSource, | ||
| callerPackageName = callerPackageName, | ||
| ) == BiometricDataSource.Simprints | ||
| if (isBiometricDataSourceSimprints) { |
Contributor
There was a problem hiding this comment.
While there's nothing wrong with this approach - can we use the same structure that Alex used for identification so code is more consistent?
BurningAXE
approved these changes
Jul 11, 2024
|
alex-vt
deleted the
bugfix/MS-577-verify-non-simprints-source-guid-check-skip
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed verification with co-sync, when the biometric data source is the data collection app.
Related fix for identification: #806