[MS-587] Resolve release compilation errors#818
Merged
Conversation
BurningAXE
approved these changes
Jul 17, 2024
BurningAXE
reviewed
Jul 17, 2024
| # Do not obfuscate names in out packages` | ||
| -keepnames class com.simprints.** { *; } | ||
| # Do not obfuscate names in simprints package | ||
| -keep class com.simprints.** { *; } |
Contributor
There was a problem hiding this comment.
Is this a related change?
Collaborator
Author
There was a problem hiding this comment.
yes
As seen in this trail, we should keep the class functions and fields, not just the names
alex-vt
requested changes
Jul 17, 2024
Co-authored-by: Alex / Oleksii <oleksiy.vt@gmail.com>
|
alex-vt
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Due to inconsistencies between AGP, R8, KSP, and Hilt versions, we encountered issues when creating release builds. Over the last two days, I tried many workarounds mentioned in GitHub issues but found it safer to roll back. Downgrading the AGP version to the last known working version (in the release 2024.1.* branch) resolved the problem.
The error trace: