Skip to content

Logging current and received session ID values before throwing exception #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Jul 29, 2024
Merged

Logging current and received session ID values before throwing exception #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...va/com/simprints/feature/clientapi/mappers/request/validators/ConfirmIdentityValidator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.simprints.feature.clientapi.mappers.request.validators
import com.simprints.feature.clientapi.exceptions.InvalidRequestException
import com.simprints.feature.clientapi.mappers.request.extractors.ConfirmIdentityRequestExtractor
import com.simprints.feature.clientapi.models.ClientApiError
import com.simprints.infra.logging.Simber


internal class ConfirmIdentityValidator(
Expand Down Expand Up @@ -30,9 +31,11 @@ internal class ConfirmIdentityValidator(
private fun validateSessionId(sessionId: String) {
if (sessionId.isBlank())
throw InvalidRequestException("Missing Session ID", ClientApiError.INVALID_SESSION_ID)
if (currentSessionId != sessionId)
if (currentSessionId != sessionId) {
// TODO Remove in 2024.2.1 or when root cause of "Invalid Session ID" error is found
Simber.i("Mismatched IDs: '$currentSessionId' != '$sessionId'")
throw InvalidRequestException("Invalid Session ID", ClientApiError.INVALID_SESSION_ID)

}
}

private fun validateSelectedGuid(selectedId: String) {
Expand Down