Skip to content

MS-593 Camera permission revokation fix#836

Merged
luhmirin-s merged 2 commits into
release/2024.2.0from
hotfix/MS-593-camera-permission-fix
Jul 30, 2024
Merged

MS-593 Camera permission revokation fix#836
luhmirin-s merged 2 commits into
release/2024.2.0from
hotfix/MS-593-camera-permission-fix

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

  • The app process is silently restarted when revoking permission in settings without calling onCleared() or any other indication within the view model.
  • This causes the VM recreation when navigating back to SID. Since the onCleared() has not been called there is nothing in the steps cache and the flow is forcibly closed on the next handleResult()/doOnNextStep() call.
  • The only way to be sure that the step cache is being preserved is to save the steps each time the flow proceeds to the next step or returns the final result.
  • Since the step list is always relatively short (less than 10 items) parsing to/from JSON should take a negligible amount of time. This could also make the cache and state restoration more consistent in other scenarios that involve navigating away from SID mid-flow.

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team July 29, 2024 13:27
@cla-bot cla-bot Bot added the ... label Jul 29, 2024
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit faa84e4 into release/2024.2.0 Jul 30, 2024
@luhmirin-s luhmirin-s deleted the hotfix/MS-593-camera-permission-fix branch July 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants