Skip to content

[MS-592] Fix for face unable to be captured after app resumes from background #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-vt merged 2 commits into from
Jul 31, 2024
Merged

[MS-592] Fix for face unable to be captured after app resumes from background #840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d2d89
MS-592 Fix for face unable to be captured after app resumes from back…
alex-vt Jul 30, 2024
56285d3
MS-592 Fix for face capture target area shifting after app resumes fr…
alex-vt Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ure/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
private val binding by viewBinding(FragmentLiveFeedbackBinding::bind)

private lateinit var screenSize: Size
private lateinit var targetResolution: Size

private val launchPermissionRequest = registerForActivityResult(
ActivityResultContracts.RequestPermission(),
Expand Down Expand Up @@ -104,20 +105,23 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

/** Initialize CameraX, and prepare to bind the camera use cases */
private fun setUpCamera() = lifecycleScope.launch {
if (::cameraExecutor.isInitialized) {
if (::cameraExecutor.isInitialized && !cameraExecutor.isShutdown) {
return@launch
}
// Initialize our background executor
cameraExecutor = Executors.newSingleThreadExecutor()
// ImageAnalysis
//Todo choose accurate output image resolution that respects quality,performance and face analysis SDKs https://simprints.atlassian.net/browse/CORE-2569
val targetResolution = Size(binding.captureOverlay.width, binding.captureOverlay.height)
if (!::targetResolution.isInitialized) {
targetResolution = Size(binding.captureOverlay.width, binding.captureOverlay.height)
}
val imageAnalyzer = ImageAnalysis.Builder().setTargetResolution(targetResolution)
.setOutputImageFormat(OUTPUT_IMAGE_FORMAT_RGBA_8888).build()
imageAnalyzer.setAnalyzer(cameraExecutor, ::analyze)
// Preview
val preview = Preview.Builder().setTargetResolution(targetResolution).build()
val cameraProvider = ProcessCameraProvider.getInstance(requireContext()).await()
cameraProvider.unbindAll()
Comment thread
BurningAXE marked this conversation as resolved.
cameraProvider.bindToLifecycle(
this@LiveFeedbackFragment, DEFAULT_BACK_CAMERA, preview, imageAnalyzer
)
Expand Down