[MS-596] Log verification issue#843
Merged
Merged
Conversation
meladRaouf
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s and
ybourgery
and removed request for
a team
|
alexandr-simprints
approved these changes
Jul 31, 2024
luhmirin-s
approved these changes
Jul 31, 2024
| ?: AppErrorResponse(AppErrorReason.UNEXPECTED_ERROR) | ||
| ?: AppErrorResponse(AppErrorReason.UNEXPECTED_ERROR).also { | ||
| //if subject enrolled with an SDK and the user tries to verify with another SDK | ||
| Simber.tag(CrashReportTag.MATCHING.name).e("No match results found") |
Contributor
There was a problem hiding this comment.
The message feels a bit too generic, maybe something like "No match results due to SDK mismatch"?
Collaborator
Author
There was a problem hiding this comment.
@luhmirin-s There are other scenarios where the matching result can be empty, such as a crash in one of the SDKs. This is why I chose a generic log message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subject is enrolled using one SDK and then verified with another SDK (by selecting a different age group), SID returns an unexpected error. In this PR, I'm logging this matching issue as a non-fatal error until we implement the proper behavior for migrating between SDKs.