MS-671 Replace custom constructor with factory method in setting password dialog fragment#876
Merged
Merged
Conversation
Contributor
luhmirin-s
commented
Aug 26, 2024
luhmirin-s
commented
- Custom constructors cannot be used by the system to restore the view state and instead cause the crash.
- I could not figure out how to reliably unit-test the fragment with the new setup so the tests are disabled for now. We will have to rely on the manual test cases for the UI parts.
…word dialog fragment
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
|
alexandr-simprints
approved these changes
Aug 27, 2024
meladRaouf
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.