Skip to content

MS-276 Respect subject query#880

Merged
luhmirin-s merged 2 commits into
mainfrom
feature/MS-276-respect-subject-query
Aug 29, 2024
Merged

MS-276 Respect subject query#880
luhmirin-s merged 2 commits into
mainfrom
feature/MS-276-respect-subject-query

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Aug 28, 2024 •
edited
Loading

  • Added filtering of co-synced records from CommCare based on values in the subject query and data available in subjectActions to limit the 1:N/1:1 search only to relevant records.
  • Additionally, added an option to provide caseId as a metadata field and pass this data as part of the subject query so that the co-sync data source could skip a case ID lookup.

@cla-bot cla-bot Bot added the ... label Aug 28, 2024
@luhmirin-s luhmirin-s force-pushed the feature/MS-276-respect-subject-query branch from 8682981 to b22f81f Compare August 28, 2024 14:30
@luhmirin-s luhmirin-s force-pushed the feature/MS-276-respect-subject-query branch from b22f81f to 369af42 Compare August 28, 2024 14:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 28, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@luhmirin-s luhmirin-s requested a review from a team August 29, 2024 06:39
@luhmirin-s luhmirin-s marked this pull request as ready for review August 29, 2024 06:39
@luhmirin-s luhmirin-s requested review from BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team August 29, 2024 06:39
@luhmirin-s luhmirin-s merged commit 4fe7421 into main Aug 29, 2024
@luhmirin-s luhmirin-s deleted the feature/MS-276-respect-subject-query branch August 29, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandr-simprints alexandr-simprints alexandr-simprints approved these changes

@BurningAXE BurningAXE Awaiting requested review from BurningAXE BurningAXE was automatically assigned from Simprints/sid-reviewers

@alex-vt alex-vt Awaiting requested review from alex-vt alex-vt was automatically assigned from Simprints/sid-reviewers

@meladRaouf meladRaouf Awaiting requested review from meladRaouf meladRaouf was automatically assigned from Simprints/sid-reviewers

@TristramN TristramN Awaiting requested review from TristramN TristramN was automatically assigned from Simprints/sid-reviewers

@ybourgery ybourgery Awaiting requested review from ybourgery ybourgery was automatically assigned from Simprints/sid-reviewers

Assignees

No one assigned

Labels

...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luhmirin-s @alexandr-simprints