Skip to content

MS-718 Use accurate face detection method from ROC v3 #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Sep 12, 2024
Merged

MS-718 Use accurate face detection method from ROC v3 #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions face/infra/roc-v3/src/main/java/com/simprints/face/infra/rocv3/detection/RocV3Detector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class RocV3Detector @Inject constructor() : FaceDetector {
val template = roc3.new_uint8_t_array(roc3.ROC_FACE_FAST_FV_SIZE.toInt())
val yaw = roc3.new_float()
val quality = roc3.new_float()
val face = if (isFaceDetected(grayImage, detection)) {
val face = if (isFaceDetected(coloredImage, detection)) {
Copy link
Copy Markdown
Collaborator

@meladRaouf meladRaouf Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luhmirin-s Why did you change this line?

Copy link
Copy Markdown
Contributor Author

@luhmirin-s luhmirin-s Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The accurate method uses color images as per documentation.

generateFaceTemplateFromImage(
coloredImage, grayImage, detection, yaw, template, quality
)
Expand Down Expand Up @@ -127,7 +127,7 @@ class RocV3Detector @Inject constructor() : FaceDetector {
)
val n = roc3.new_size_t()

roc3.roc_embedded_detect_faces(
roc3.roc_embedded_detect_faces_accurate(
image,
roc3.size_t_value(adaptiveMinimumSize),
MAX_FACE_DETECTION,
Expand Down