[MS-491] limit fingerprint scan attempts#905
Conversation
…cans. Capture state is refactored to have common classes that represent the scan process under a single parent class
…o the use-case file
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
BurningAXE
left a comment
BurningAXE
left a comment
There was a problem hiding this comment.
We should handle NEC, too. Otherwise looks good!
| ): Boolean = when (fingerState) { | ||
| is CaptureState.ScanProcess -> { | ||
| val noFingerDetectedThreshold = | ||
| configuration.secugenSimMatcher?.maxCaptureAttempts?.noFingerDetected?.takeIf { it > 1 } |
There was a problem hiding this comment.
Is this feature only applicable to SimMatcher? If so, we should take care to either not call this use case when using NEC or pass the SDK used currently and skip the check for NEC.
There was a problem hiding this comment.
That's a good question, actually. Let's take it to Slack first
I've checked the description for the MS-491 task, it states that both SDKs should be included:
This should apply to all fingerprint SDKs (SimMatcher and NEC currently)
There was a problem hiding this comment.
OK, then the use case should lookup the configuration for the particular SDK used. Currently it's always checking the SimMatcher config.
There was a problem hiding this comment.
Great spot! Fixing it now
…ic FingerprintSdkConfiguration (SimMatcher or NEC) so that 'maxCaptureAttempts' is taken from the currently used SDKˆ
|
3 participants
There is now a limit to the amount of 'No Finger detected' scans before the user is automatically navigated to the next finger.
40and is stored in theIsNoFingerDetectedLimitReachedUseCase.MAXIMUM_LIMIT_OF_NO_FINGER_DETECTED_SCANSConfiguration -> Fingerprint -> SimMatcher40is usedOther Changes
To accommodate the newly added
noFingerDetectedThreshold, theCaptureStatesealed class was refactored to have the following subclasses:CaptureState.NotCollectedCaptureState.SkippedCaptureState.ScanProcess- number of bad scans and no-finger-detected is stored here