MS-71 Moving image manipulation closer to CameraX API#906
Merged
Conversation
Contributor
luhmirin-s
commented
Sep 17, 2024
luhmirin-s
commented
- Set a flag in the camera to pre-rotate images and always return them with the ROTATION_0 value
- Move cropping from the view model to the image processing pipeline in the camera API.
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
|
Contributor
alexandr-simprints
left a comment
alexandr-simprints
left a comment
There was a problem hiding this comment.
Have you checked that the device rotation while in preview doesn't affect the calculations in the CropToTargetOverlayAnalyzer?
Otherwise, looks good
Contributor
Author
|
@alexandr-simprints I did rotation during capture and it worked as expected. It seems that the camera pipeline is fully rebuilt on rotation therefore, the cropper is also rebuilt. |
alexandr-simprints
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.