MS-676 Sync config button#907
Merged
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
|
Contributor
alexandr-simprints
left a comment
alexandr-simprints
left a comment
There was a problem hiding this comment.
Looks good.
Can you please try the following scenario:
- Make sure the config is password protected, so that the screen shows the dialog
- Set 'Don't keep activities' in the Developer Settings
- Navigate to
SID->Settings->Update Configuration - Make sure dialog is displayed
- Minimize the app by pressing the home button or navigating to another app
- Return to SID
Verify that only a single instance of dialog is displayed and that the dialog is functional.
Once confirmed, approving the PR
Contributor
Author
|
@alexandr-simprints works as expected (it is exact same mechanism as with the language list). |
alexandr-simprints
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.