[MS-719] Missing callback event after license error#908
Merged
alexandr-simprints merged 2 commits intoSep 23, 2024
Conversation
…iViewModel so that error callbacks can be saved after the error/alert screen is closed
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
luhmirin-s
approved these changes
Sep 19, 2024
|
luhmirin-s
deleted the
MS-719-missing-callback-event-after-license-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is confirmed that all error responses need to create callback events.
Since the
OrchestratorViewModelalready has all the mechanisms for handling the callback events, all fragment error result handlers now callorchestratorVm.handleErrorResponse(...)method in order to complete the flow with theAppErrorResponse