Skip to content

[MS-742] Remove ProGuard rules from library modules and consolidate them in the app module#918

Merged
meladRaouf merged 3 commits into
mainfrom
use-single-proguard-file
Oct 1, 2024
Merged

[MS-742] Remove ProGuard rules from library modules and consolidate them in the app module#918
meladRaouf merged 3 commits into
mainfrom
use-single-proguard-file

Conversation

@meladRaouf
Copy link
Copy Markdown
Collaborator

  • Removed proguard-rules.pro files from all library modules.
  • Consolidated ProGuard rules in the id module, as we have minimal custom rules per module.
  • Simplifies project structure and ensures consistent ProGuard handling across all modules.

@cla-bot cla-bot Bot added the ... label Sep 27, 2024
@meladRaouf meladRaouf requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, luhmirin-s and ybourgery and removed request for a team September 27, 2024 21:18
@meladRaouf meladRaouf force-pushed the use-single-proguard-file branch from 3739da9 to 17c39cb Compare September 27, 2024 21:42
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all the removals, but not many are added back to the app module. Aren't the hilt, jni and webview rules required for something?

@meladRaouf
Copy link
Copy Markdown
Collaborator Author

I see all the removals, but not many are added back to the app module. Aren't the hilt, jni and webview rules required for something?

@luhmirin-s

I found that the Hilt rules are automatically added to the app's ProGuard rules file.
As for the other com.simprints.** rules, they are also included in the same app-wide file.
About the WebView rules—where did you get them from?

@luhmirin-s
Copy link
Copy Markdown
Contributor

I found that the Hilt rules are automatically added to the app's ProGuard rules file. As for the other com.simprints.** rules, they are also included in the same app-wide file. About the WebView rules—where did you get them from?

In this file - fingerprint/infra/simafis-wrapper/consumer-rules.pro

@meladRaouf
Copy link
Copy Markdown
Collaborator Author

I found that the Hilt rules are automatically added to the app's ProGuard rules file. As for the other com.simprints.** rules, they are also included in the same app-wide file. About the WebView rules—where did you get them from?

In this file - fingerprint/infra/simafis-wrapper/consumer-rules.pro

@luhmirin-s it is a commented code

@meladRaouf meladRaouf merged commit 1a90178 into main Oct 1, 2024
@meladRaouf meladRaouf deleted the use-single-proguard-file branch October 1, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants