[MS-790] Add follow-up steps to session steps instead of replacing them#970
Merged
Conversation
BurningAXE
requested review from
a team,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s,
meladRaouf and
ybourgery
and removed request for
a team
BurningAXE
force-pushed
the
enrol-last-after-confirm
branch
from
59cfaa3 to
18d6329
Compare
alex-vt
approved these changes
Nov 11, 2024
Contributor
alex-vt
left a comment
alex-vt
left a comment
There was a problem hiding this comment.
Just in case a check: is this fix supposed to be in release/2024.2.1, not in main?
Contributor
Author
We'll decide tomorrow but there are 3 options:
|
luhmirin-s
approved these changes
Nov 11, 2024
BurningAXE
force-pushed
the
enrol-last-after-confirm
branch
from
18d6329 to
3f3b99e
Compare
BurningAXE
force-pushed
the
enrol-last-after-confirm
branch
from
3f3b99e to
2e792f6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously each action (including follow-ups) replaced old steps (in the Orchestrator and consequently in the OrchestratorCache) with its own steps. This lead to the issue where the following actions:
lead to Enrol Last failing because when Enrol Last looks in the Cache it only finds the step(s) for Confirm Identity.
With this fix each follow-up only adds its steps to the ones already in the cache. This way all session steps are available regardless of how many follow-ups have happened. The Cache is cleared when a new session is created so this change should not lead to mixing of steps between sessions. That said - can you find any edge cases where this may backfire?