Skip to content

MS-801 Add data export button to alert screen#974

Merged
luhmirin-s merged 1 commit into
mainfrom
feature/MS-801-alert-data-export
Nov 21, 2024
Merged

MS-801 Add data export button to alert screen#974
luhmirin-s merged 1 commit into
mainfrom
feature/MS-801-alert-data-export

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

Example of data exported to the clipboard:

Event ID:   229155a7-1588-408a-bf92-e2f16ac6ad8c
Timestamp:  1731597053343
Project ID: xRmp384ofU6dvylF1Hao
User ID:    Sergejs
Device ID:  d294a268b0d54f58
Session ID: c36ed54b-621c-47f3-845b-87d7b52c9e7f
Alert type: INVALID_SESSION_ID

Figma design

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team November 14, 2024 15:27
@cla-bot cla-bot Bot added the ... label Nov 14, 2024
Copy link
Copy Markdown
Collaborator

@ybourgery ybourgery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be good to try to be able to export more details about the root cause of the alert screen, e.g. the exception that led to the issue as when you have an unexpected error it will help to find the root cause.

@luhmirin-s
Copy link
Copy Markdown
Contributor Author

I initially wanted to add it, but we are not propagating the actual exception to the alert screen. And in many cases, there is no exception at all.

As a side note - I was considering logging a non-fatal with a UUID in the title or a field so that logs could be searchable in Crashlytics. But it felt a bit overkill, since we are already logging the "unexpected" exceptions directly.

@luhmirin-s luhmirin-s force-pushed the feature/MS-801-alert-data-export branch from 2c5dc5a to 84acc47 Compare November 14, 2024 15:45
@ybourgery
Copy link
Copy Markdown
Collaborator

Ah yes but sometimes you can have a given alert for several exceptions, for example the INVALID_SESSION_ID can be there because the session id is empty or invalid. But if it's too complex to implement it's ok

@luhmirin-s luhmirin-s force-pushed the feature/MS-801-alert-data-export branch from 84acc47 to 2055d3b Compare November 21, 2024 13:04
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit 8fb3acf into main Nov 21, 2024
@luhmirin-s luhmirin-s deleted the feature/MS-801-alert-data-export branch November 21, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants