MS-825 Ignore image transfer cancellation exception to avoid breaking user flow#980
Merged
Merged
Conversation
Contributor
luhmirin-s
commented
Nov 19, 2024
luhmirin-s
commented
- Cancellation exception is expected when the task is cancelled, so no extra error handling is required - UI is automatically reset to a starting state.
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
|
BurningAXE
approved these changes
Nov 19, 2024
Contributor
|
Is this going to the release or in |
Contributor
Author
|
It was initially flagged as part of the release, but it is a minor issue that could go into main first. |
luhmirin-s
force-pushed
the
bugfix/MS-825-image-transfer-crash
branch
from
e6d7009 to
407ba58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.