Skip to content

[MS-826] Implement concurrent execution in scanner module#982

Merged
meladRaouf merged 5 commits into
release/2024.2.1from
scanner-concurrent-execution
Nov 27, 2024
Merged

[MS-826] Implement concurrent execution in scanner module#982
meladRaouf merged 5 commits into
release/2024.2.1from
scanner-concurrent-execution

Conversation

@meladRaouf
Copy link
Copy Markdown
Collaborator

@meladRaouf meladRaouf commented Nov 20, 2024 •
edited
Loading

Changes:

  1. Message Channels:

    • Added coroutine Mutex to CypressOtaMessageChannel, MainMessageChannel, StmOtaMessageChannel, and RootMessageChannel for safe, single-task execution.

  2. RXJava Refactor:

    • Removed RXJava from the scanner's top layer, keeping it only in the read/write layer.
    • Switched to coroutines to reduce context switching between RXJava and coroutine schedulers.

Testing:

  • Verified NEC and SimMatcher flows with live feedback and LEDs, no disconnections.
  • OTA testing planned.

@cla-bot cla-bot Bot added the ... label Nov 20, 2024
@meladRaouf meladRaouf marked this pull request as draft November 20, 2024 09:58
@meladRaouf meladRaouf force-pushed the scanner-concurrent-execution branch 3 times, most recently from 85e5818 to be6fed0 Compare November 24, 2024 15:19
@meladRaouf meladRaouf force-pushed the scanner-concurrent-execution branch from be6fed0 to d9aa8ac Compare November 24, 2024 23:16
@meladRaouf meladRaouf marked this pull request as ready for review November 25, 2024 00:21
@meladRaouf meladRaouf requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, luhmirin-s and ybourgery and removed request for a team November 25, 2024 00:21
@meladRaouf meladRaouf changed the base branch from main to release/2024.2.1 November 25, 2024 05:21
luhmirin-s
luhmirin-s approved these changes Nov 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle, but I have styling nitpicks.

Comment thread ...a/scanner/src/main/java/com/simprints/fingerprint/infra/scanner/v2/channel/MessageChannel.kt
Comment thread ...src/main/java/com/simprints/fingerprint/infra/scanner/capture/FingerprintCaptureWrapperV2.kt Outdated
Comment thread ...ra/scanner/src/main/java/com/simprints/fingerprint/infra/scanner/v2/scanner/CreateScanner.kt Outdated
Comment thread ...ra/scanner/src/main/java/com/simprints/fingerprint/infra/scanner/v2/scanner/CreateScanner.kt Outdated
Comment thread ...n/java/com/simprints/fingerprint/infra/scanner/v2/scanner/ScannerExtendedInfoReaderHelper.kt Outdated
Comment thread ...java/com/simprints/fingerprint/infra/scanner/v2/scanner/errorhandler/ResponseErrorHandler.kt Outdated
Comment thread .../java/com/simprints/fingerprint/infra/scanner/v2/scanner/ota/cypress/CypressOtaController.kt
Comment thread ...anner/src/main/java/com/simprints/fingerprint/infra/scanner/v2/tools/WrapErrorFromScanner.kt Outdated
Comment thread ...a/scanner/src/main/java/com/simprints/fingerprint/infra/scanner/v2/tools/reactive/RxTools.kt
Comment thread ...ra/scanner/src/main/java/com/simprints/fingerprint/infra/scanner/wrapper/ScannerWrapperV2.kt Outdated
@meladRaouf meladRaouf force-pushed the scanner-concurrent-execution branch from 5219cf8 to ae6c5b5 Compare November 25, 2024 09:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@meladRaouf meladRaouf merged commit 1e3fe70 into release/2024.2.1 Nov 27, 2024
@meladRaouf meladRaouf deleted the scanner-concurrent-execution branch November 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BurningAXE BurningAXE BurningAXE left review comments

@luhmirin-s luhmirin-s luhmirin-s approved these changes

@alex-vt alex-vt Awaiting requested review from alex-vt alex-vt was automatically assigned from Simprints/sid-reviewers

@TristramN TristramN Awaiting requested review from TristramN TristramN was automatically assigned from Simprints/sid-reviewers

@ybourgery ybourgery Awaiting requested review from ybourgery ybourgery was automatically assigned from Simprints/sid-reviewers

@alexandr-simprints alexandr-simprints Awaiting requested review from alexandr-simprints

Assignees

No one assigned

Labels

...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meladRaouf @luhmirin-s @BurningAXE @alexandr-simprints