MS-802 Troubleshooting screen base#984
Merged
Merged
Conversation
Contributor
luhmirin-s
commented
Nov 20, 2024
luhmirin-s
commented
- Implemented the base to display more complex troubleshooting information in the future. For now, it is mostly placeholders.
- The screen is hidden behind multiple clicks within a second on the "About->Sync config" in settings or the logo on the login request page. Additionally, the option is settings is protected by the settings password since it will eventually contain project-specific info.
- I decided against adding a feature flag check since it would not be available before login.
- I also decided not to introduce different settings passwords - the same users who have access to the settings changes are the intended audience for the troubleshooting screens anyway. This could change in future.
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
force-pushed
the
feature/MS-802-poweruser-menu
branch
4 times, most recently
from
3dfb78f to
ae5bc54
Compare
luhmirin-s
force-pushed
the
feature/MS-802-poweruser-menu
branch
from
ae5bc54 to
8720577
Compare
|
Collaborator
|
Since the dashboard module is growing larger, would it be good to create a new module for this screen? |
Contributor
Author
|
@meladRaouf That's a good point; I will look into that. Since there are already a couple of PRs in a chain and I don't really want to rebase all of them, I will do the extraction into a module as a separate PR between phases 1 and 2 of the work. |
Contributor
|
Should this PR be reviewed now, or shall we wait for the module separation? |
Contributor
Author
|
@alexandr-simprints please review it now. Module separation should not affect much of the content of the classes, just the location. |
meladRaouf
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.