[MS-831] Ensure audio alerts play immediately#995
Merged
Conversation
meladRaouf
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s and
ybourgery
and removed request for
a team
luhmirin-s
approved these changes
Nov 28, 2024
meladRaouf
force-pushed
the
scanner-concurrent-execution
branch
from
1935bf1 to
07545e4
Compare
|
BurningAXE
reviewed
Nov 28, 2024
| private suspend fun setUiAfterScan(isGoodScan: Boolean) { | ||
| // Check if the previous state was ScanCompleted to avoid displaying the bad or good scan UI twice | ||
| // There's no need to check the configuration, as the good/bad scan visual notifications apply across all LED modes. | ||
| if (previousState == FingerprintScanState.ScanCompleted) { |
Contributor
There was a problem hiding this comment.
No need to check previous state anymore?
Collaborator
Author
There was a problem hiding this comment.
I discovered that this check was part of an old implementation where FingerprintScanState.ScanCompleted was being sent twice, which is not valid now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.