MS-804 Troubleshooting event scope log#996
Merged
Merged
Conversation
Contributor
luhmirin-s
commented
Nov 28, 2024
luhmirin-s
commented
- Added a generic list layout and adapter that could be reused for other troubleshooting log screens.
- Created a new screen that lists all local event scopes with a "details" screen that lists all of the events in the scope.
- Added a special "toSafeString()" method to all event payload classes that expose only technical (sometimes even tokenized) data to be displayed in the log screen.
luhmirin-s
force-pushed
the
feature/MS-804-events-log
branch
from
8618cd5 to
74b8b60
Compare
Contributor
Author
|
Would it be worth adding tests for all the "toSafeString()" methods? |
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
alexandr-simprints
approved these changes
Dec 4, 2024
Contributor
Generally, I would advocate that it is worth it to make sure that the sensitive data isn't 'leaked' there, and to create an additional static verification for any potential changes. It doesn't fully remove the chance of sensitive data being 'leaked' but minimizes the chances of any unintentional human error |
|
Base automatically changed from
feature/MS-803-network-troubleshooting
to
main
December 5, 2024 10:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.