[MS-565] Ensure any needed firmware is downloaded after successful login#998
Merged
BurningAXE merged 1 commit intoDec 4, 2024
Conversation
BurningAXE
requested review from
a team,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
reviewed
Nov 29, 2024
| } | ||
| } | ||
|
|
||
| private suspend fun fetchFirmwareIfNeeded() { |
Contributor
There was a problem hiding this comment.
A private method for a single line feels a bit redundant.
Also, what is the "ifNeeded" part referring to? There are no checks in the method.
Contributor
Author
There was a problem hiding this comment.
Wanted to make it clear that it's safe to call for all project configurations. Obviously not successful :D Will replace with a comment.
BurningAXE
force-pushed
the
MS-565-Explicitly-download-any-OTA-firmware-after-successful-login
branch
from
0eda47c to
221b5eb
Compare
|
luhmirin-s
approved these changes
Dec 2, 2024
alexandr-simprints
approved these changes
Dec 2, 2024
luhmirin-s
deleted the
MS-565-Explicitly-download-any-OTA-firmware-after-successful-login
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.