MS-628 LibSimprints API versioning support#100
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
alexandr-simprints
approved these changes
Aug 22, 2024
| val CREATOR = object : Creator<Identification> { | ||
|
|
||
| override fun createFromParcel(parcel: Parcel): Identification? { | ||
| val guid = parcel.readString().orEmpty() |
Contributor
There was a problem hiding this comment.
Have you confirmed that createFromParcel is working as expected? I remember having fun with it back in the days
Contributor
Author
There was a problem hiding this comment.
As per slack conversation - I have integrated this version in SID and then tried calling from the current "main" version of Intent Launcher (it still uses java version of LibSimprints). So I am fairly confident that it works correctly.
An error occurred while trying to automatically change base from
feature/MS-621-contracts
to
main
August 22, 2024 10:51
luhmirin-s
force-pushed
the
feature/MS-628-version-meta-info
branch
from
75bd9da to
0e41224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running the different versions of LibSimprints (pre-refactoring and post-refactoring) against the same SID version (that integrates the post-refactoring version) I realised that Parcel is a completely inadequate way to send data. The main reason is the strict requirement for marshalling/unmarshalling the data object based on the class version, i.e. adding/removing fields to a class breaks compatibility.
To fix this issue I have implemented a few crucial changes:
LibSimprints v2024.08.01return the new JSON data classes.