MS-621 Activity contract wrapper for the intent calls#97
Merged
Conversation
luhmirin-s
force-pushed
the
feature/MS-621-contracts
branch
from
1a51d4a to
5541645
Compare
luhmirin-s
force-pushed
the
feature/MS-621-contracts
branch
2 times, most recently
from
8c338d5 to
e7099cc
Compare
luhmirin-s
force-pushed
the
feature/MS-621-contracts
branch
from
e7099cc to
de3b0c3
Compare
luhmirin-s
requested review from
a team and
BurningAXE
and removed request for
a team
luhmirin-s
requested review from
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
This would allow callers to use intents directly if contracts are not possible.
alexandr-simprints
approved these changes
Aug 20, 2024
alex-vt
approved these changes
Aug 20, 2024
Contributor
Author
|
@alex-vt @alexandr-simprints I have added some important commits that are worth resetting the approvals :) |
alexandr-simprints
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major benefits of activity contact:
Ideally, we want all the integration partners to switch to the new API; therefore, we need to try to cover all possible use/edge cases before making it public.