Skip to content

Conversation

@ianfd
Copy link
Member

@ianfd ianfd commented Apr 15, 2025

No description provided.

@ianfd ianfd requested a review from Copilot April 15, 2025 06:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/laczos/mod.rs:1150

  • The new indexing logic replaces a decrementing index pattern; please verify that calculating 'idx' as 'k * js + i' preserves the intended ordering and semantics of the original algorithm.
let idx = k * js + i;

src/lib.rs:176

  • The test 'test_random_svd_computation' now uses 7 power iterations, while another test uses 2; please confirm that the discrepancy in power iteration parameters is intentional and well-documented.
let result = randomized::randomized_svd(

@ianfd ianfd merged commit 65e5142 into master Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants