TiffEncoder: Avoid buffer2D.GetSingleSpan() and use GetPixelRowSpan instead#1662
Merged
brianpopow merged 2 commits intomasterfrom Jun 14, 2021
Merged
TiffEncoder: Avoid buffer2D.GetSingleSpan() and use GetPixelRowSpan instead#1662brianpopow merged 2 commits intomasterfrom
brianpopow merged 2 commits intomasterfrom
Conversation
JimBobSquarePants
approved these changes
Jun 14, 2021
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Wow! That was quick! 😍
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
+ Coverage 84.31% 84.32% +0.01%
==========================================
Files 816 816
Lines 35824 35856 +32
Branches 4160 4167 +7
==========================================
+ Hits 30204 30235 +31
Misses 4799 4799
- Partials 821 822 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4 tasks
Contributor
|
@brianpopow @JimBobSquarePants @antonfirsov sorry, I'm a distracted, great work @brianpopow 👍 |
Member
|
No worries @IldarKhayrutdinov we move fast! 😀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As made clear with #1660 the usage of
buffer2D.GetSingleSpan()is problematic and not always guaranteed to return a complete span. This PR will change the Tiff Encoder to avoid the usage ofbuffer2D.GetSingleSpan()and useGetPixelRowSpaninstead.