Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Feb 10, 2025

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The same as #2880 but for V4.
@antonfirsov You'll like the benchmark. .NET 8 is flying!

BenchmarkDotNet v0.14.0, Windows 11 (10.0.26100.3037)
11th Gen Intel Core i7-11370H 3.30GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 9.0.200-preview.0.25057.12
  [Host]     : .NET 8.0.12 (8.0.1224.60305), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-TWXXIM : .NET 8.0.12 (8.0.1224.60305), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI

Runtime=.NET 8.0  Arguments=/p:DebugType=portable  IterationCount=3
LaunchCount=1  WarmupCount=3
Method TestImage Mean Error StdDev Ratio RatioSD Gen0 Allocated Alloc Ratio
'System.Drawing Gif' Gif/rings.gif 298.7 us 84.00 us 4.60 us 1.00 0.02 - 168 B 1.00
'ImageSharp Gif' Gif/rings.gif 345.1 us 18.31 us 1.00 us 1.16 0.02 1.4648 9584 B 57.05

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • tests/Images/External/ReferenceOutput/GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_A.gif/00.png: Language not supported
  • tests/Images/External/ReferenceOutput/GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_B.gif/00.png: Language not supported
  • tests/Images/External/ReferenceOutput/GifDecoderTests/Issue2859_LZWPixelStackOverflow_Rgba32_issue_2859_B.gif/01.png: Language not supported
  • tests/Images/Input/Gif/issues/issue_2859_A.gif: Language not supported
  • tests/Images/Input/Gif/issues/issue_2859_B.gif: Language not supported

@JimBobSquarePants JimBobSquarePants merged commit e20e47f into main Feb 10, 2025
29 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-2859-v4 branch February 10, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants