Draft PR for the bokeh blur effect#837
Closed
Sergio0694 wants to merge 9 commits intoSixLabors:masterfrom
Sergio0694:feature_bokeh-blur
Closed
Draft PR for the bokeh blur effect#837Sergio0694 wants to merge 9 commits intoSixLabors:masterfrom Sergio0694:feature_bokeh-blur
Sergio0694 wants to merge 9 commits intoSixLabors:masterfrom
Sergio0694:feature_bokeh-blur
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
==========================================
- Coverage 88.87% 88.66% -0.22%
==========================================
Files 1015 1018 +3
Lines 44240 44348 +108
Branches 3202 3207 +5
==========================================
Hits 39319 39319
- Misses 4200 4308 +108
Partials 721 721
Continue to review full report at Codecov.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is a draft PR for the bokeh blur effect.
I've added a
BokehBlurExtensionsclass, as well as aBokehBlurProcessorclass.For now I've pretty much done a 1:1 port from the Python code, and the actual convolution execution is not implemented.
The python version uses the
complex64type, which uses two 32-bits floats for the components, and the C#Complextype instead uses twodoublevalues. We should consider writing our ownComplex64struct with two floats, to save half the memory usage (and get a speed bump).Also, some of the preprocessing code might use some optimizations later on (eg. either some parallelization, or a switch to unsafe code to reduce the overhead of iterators and whatnot) if this can lead to a noticeable advantage (will need some benchmarks to test this).