Introduce representation-agnostic Color type #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(non-namespace providing)
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
==========================================
- Coverage 89.6% 89.17% -0.43%
==========================================
Files 1060 1079 +19
Lines 46542 47573 +1031
Branches 3268 3270 +2
==========================================
+ Hits 41703 42425 +722
- Misses 4128 4396 +268
- Partials 711 752 +41
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
==========================================
- Coverage 89.61% 89.29% -0.33%
==========================================
Files 1060 1079 +19
Lines 46586 47631 +1045
Branches 3272 3273 +1
==========================================
+ Hits 41750 42530 +780
- Misses 4125 4387 +262
- Partials 711 714 +3
Continue to review full report at Codecov.
|
JimBobSquarePants
requested changes
May 12, 2019
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
I absolutely love the direction this has gone. I think it's a quantum leap in usability. 👍
I think we can tighten up some of the code reuse though taking advantage of implicit casting. I'm happy to make those changes.
| using (IFrameQuantizer<TPixel> palleteFrameQuantizer = palleteQuantizer.CreateFrameQuantizer(image.GetConfiguration())) | ||
| using (QuantizedFrame<TPixel> paletteQuantized = palleteFrameQuantizer.QuantizeFrame(frame)) | ||
| using (IFrameQuantizer<TPixel> palleteFrameQuantizer = | ||
| new PaletteFrameQuantizer<TPixel>(this.quantizer.Diffuser, quantized.Palette)) |
Member
There was a problem hiding this comment.
This is all so much nicer! 😍
| /// <param name="indexedPixels">The span of indexed pixels.</param> | ||
| /// <param name="stream">The stream to write to.</param> | ||
| public void Encode(Span<byte> indexedPixels, Stream stream) | ||
| public void Encode(ReadOnlySpan<byte> indexedPixels, Stream stream) |
JimBobSquarePants
approved these changes
May 12, 2019
tocsoft
reviewed
May 12, 2019
| /// </summary> | ||
| /// <param name="source">The <see cref="Rgba64"/>.</param> | ||
| /// <returns>The <see cref="Color"/>.</returns> | ||
| public static implicit operator Color(Rgba64 source) => new Color(source); |
Member
There was a problem hiding this comment.
shouldn't these implicit operators be on the Pixel type instead of Color? there are alot more Pixel types after all.
Member
Author
There was a problem hiding this comment.
Good point! I think I will change this.
add micro-optimizations
# Conflicts:
# src/ImageSharp/Processing/Processors/Quantization/QuantizedFrame{TPixel}.cs
antonfirsov
added a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
Introduce representation-agnostic Color type
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Colorstruct with a hidden internal hi-res representation, that is convertible to all pixel typesColor.BlackorColor.WebSafePalette)Colortype now.Coloron all public API-s (Consequence:PaletteQuantizer<TPixel>has been dropped.)ReadOnlyMemory<T>on public API-s instead ofT[]QuantizedFrame<T>.GetPixelSpan()returnsReadOnlySpan<T>. Populating the span is an implementation detail. IntroduceIQuantizedFrame<T>to maintain clean abstractions here.ColorBuilder<T>.FromRGBA()toFromRgbaConsequence on our terminlogy
Color ≠ Pixel any longer. Color is a general term, pixel is a representation drawable on an
Image<TPixel>.