Skip to content

Conversation

@DuckySoLucky
Copy link
Member

This pull request introduces several improvements and refactors to the accessories handling logic, primarily focusing on simplifying inventory processing and enhancing the clarity of accessory status messages. The main changes include switching the inventory processing to use local logic instead of an external dependency, updating how inactive accessories are annotated, and adding new environment variables for MongoDB configuration.

Refactoring and Inventory Processing:

  • Replaced the use of skyhelpernetworthgo for accessory inventory calculation in src/routes/accessories.go with local calls to stats.GetInventory, simplifying the code and removing an external dependency. [1] [2]

Accessory Status Annotation Improvements:

  • Updated inactive accessory lore messages to specify the source inventory or reason (e.g., found in a specific inventory, duplicate, lower rarity, upgraded), improving clarity for users. [1] [2] [3]
  • Added logic to remove inactive status lore when an accessory becomes active, ensuring accurate display of accessory states.

Configuration Updates:

  • Added MONGO_URI and MONGO_DB_NAME environment variables to .env.example for MongoDB configuration.

Code Cleanup:

  • Removed unnecessary timing and logging code from the emoji population logic in src/db/mongo.go. [1] [2]

@DuckySoLucky DuckySoLucky merged commit b5418c6 into prod Nov 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants