Conversation
rlepigre-skylabs-ai
left a comment
There was a problem hiding this comment.
If we're bumping, it might make sense to bump all dependencies that can be bumped, including OCaml. I'm fine doing this in several steps though, my only concern is that it's more disruption to do it in several.
Oh agree — I bumped OCaml too by hand, but probably I should have removed all constraints, and didn't. |
a88ed8f to
96e84e8
Compare
Goal: let opam pick new versions.
Implementation: `s/ \{[^|&]*$//` regexp.
Because `opam install ../skylabs-deps.opam` doesn't pick the latest compiler.
This is based on the output of ``` opam install -y dev/opam-deps/skylabs-deps.opam -j5 && opam lock skylabs-deps ``` I readded conf-linux-libc-dev and ocaml-option-fp by hand.
96e84e8 to
bcc4cac
Compare
|
Looks like |
|
The upstream issue is ocaml/dune#12904. |
Just a proposal for testing. This would let us solve the cram test issues at least.
This wasn't scheduled and finding compatible versions was more than the "5 minutes" I was hoping but still okayish.
Fix https://github.com/SkyLabsAI/skylabs-fm/issues/259.