Skip to content

chore: Bump opam deps for new dune#144

Draft
pgiarrusso-sl wants to merge 4 commits intomainfrom
chore/bump
Draft

chore: Bump opam deps for new dune#144
pgiarrusso-sl wants to merge 4 commits intomainfrom
chore/bump

Conversation

@pgiarrusso-sl
Copy link
Copy Markdown
Contributor

@pgiarrusso-sl pgiarrusso-sl commented Apr 16, 2026

Just a proposal for testing. This would let us solve the cram test issues at least.

This wasn't scheduled and finding compatible versions was more than the "5 minutes" I was hoping but still okayish.

Fix https://github.com/SkyLabsAI/skylabs-fm/issues/259.

@pgiarrusso-sl pgiarrusso-sl changed the title chore: Bump opam deps chore: Bump opam deps for new dune Apr 16, 2026
Copy link
Copy Markdown
Contributor

@rlepigre-skylabs-ai rlepigre-skylabs-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're bumping, it might make sense to bump all dependencies that can be bumped, including OCaml. I'm fine doing this in several steps though, my only concern is that it's more disruption to do it in several.

@pgiarrusso-sl
Copy link
Copy Markdown
Contributor Author

If we're bumping, it might make sense to bump all dependencies that can be bumped, including OCaml. I'm fine doing this in several steps though, my only concern is that it's more disruption to do it in several.

Oh agree — I bumped OCaml too by hand, but probably I should have removed all constraints, and didn't.

Goal: let opam pick new versions.
Implementation: `s/ \{[^|&]*$//` regexp.
Because `opam install ../skylabs-deps.opam` doesn't pick the latest compiler.
This is based on the output of
```
opam install -y dev/opam-deps/skylabs-deps.opam -j5 && opam lock skylabs-deps
```

I readded conf-linux-libc-dev and ocaml-option-fp by hand.
@rlepigre-skylabs-ai
Copy link
Copy Markdown
Contributor

Looks like dune changed where it writes it's log, but our tooling still expects _build/log to exist...

@pgiarrusso-sl
Copy link
Copy Markdown
Contributor Author

The upstream issue is ocaml/dune#12904.
Fixed in ocaml/dune#13015 and ocaml/dune#13183 and
ocaml/dune#12904 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants