Item Ability API

[viciscat]

It's not a new feature D:

A class that allows for parsing of the abilities of an item! wowi!
Might be unnecessary but has masks to only parse the needed things and save on resources.

[Alex33856]

It's a new feature :D

adding new feature label

[viciscat]

you scaly wag

[Copilot]

Pull request overview

This PR introduces an ItemAbility API for parsing and caching item abilities from Skyblock item lore, refactoring existing code to use this centralized approach instead of scattered regex-based parsing.

Key Changes:

• Adds new ItemAbility record class with ability name, activation type, and optional costs/cooldown
• Caches parsed abilities in ItemStack via mixin for performance
• Refactors four existing features to use the new API instead of custom regex patterns

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/main/java/de/hysky/skyblocker/utils/ItemAbility.java	New API class with regex patterns for parsing ability name, activation type, mana/soulflow costs, and cooldown from item lore
src/main/java/de/hysky/skyblocker/skyblock/teleport/PredictiveSmoothAOTE.java	Refactored to use ItemAbility API for mana cost checking instead of direct lore regex matching
src/main/java/de/hysky/skyblocker/skyblock/dwarven/PickobulusHelper.java	Simplified ability checking to use ItemAbility.hasAbility() method
src/main/java/de/hysky/skyblocker/skyblock/SwingAnimation.java	Refactored to check parsed abilities for right-click activation instead of regex matching
src/main/java/de/hysky/skyblocker/skyblock/StatusBarTracker.java	Updated mana tracking to iterate through parsed abilities instead of searching lore text
src/main/java/de/hysky/skyblocker/mixins/ItemStackMixin.java	Added caching field and getter method for abilities in ItemStack mixin
src/main/java/de/hysky/skyblocker/injected/SkyblockerStack.java	Added skyblocker$getAbilities() interface method with empty list default

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The refactored logic changes behavior from the original implementation. The old regex pattern matched any ability ending with "right click", which would include both RIGHT_CLICK and SNEAK_RIGHT_CLICK. The new code only checks for exact RIGHT_CLICK activation, missing SNEAK_RIGHT_CLICK abilities. This could cause swing animations to not display for items with sneak right-click abilities.

Suggested change

	if (ability.activation() == ItemAbility.Activation.RIGHT_CLICK) return true;
	if (ability.activation().name().endsWith("RIGHT_CLICK")) return true;

[Copilot]

The refactored logic changes behavior from the original implementation. The old code matched any ability text ending with "right click" (case-insensitive), which would include both "RIGHT CLICK" and "SNEAK RIGHT CLICK". The new code only checks for exact RIGHT_CLICK activation, potentially missing mana costs for SNEAK_RIGHT_CLICK abilities. This could cause incorrect mana tracking for items with sneak right-click abilities.

Suggested change

	if (ability.activation() == ItemAbility.Activation.RIGHT_CLICK) {
	if (ability.activation() == ItemAbility.Activation.RIGHT_CLICK
	|| ability.activation() == ItemAbility.Activation.SNEAK_RIGHT_CLICK) {

[kevinthegreat1]

@viciscat I remember you responded somewhere but can't find it. Those concerns aren't an issue right?

[viciscat]

I don't remember responding. One of us is crazy. It could be ignored, the amount of shift right click abilities seems really small. But it can be fixed by doing an || with SHIFT_RIGHT_CLICK or adding a small method to the enum to make it a little cleaner