Skip to content
This repository was archived by the owner on Mar 4, 2023. It is now read-only.

Comments

Fix members overwriting#6

Merged
Skycoder42 merged 1 commit intoSkycoder42:masterfrom
Shatur:fix-member-overwriting
Oct 11, 2020
Merged

Fix members overwriting#6
Skycoder42 merged 1 commit intoSkycoder42:masterfrom
Shatur:fix-member-overwriting

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 10, 2020

This PR fixes the following MSVC warnings:

D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_win.cpp(72,43): error C2220: the following warning is treated as an error [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_win.cpp(72,43): warning C4458: declaration of 'progressVisible' hides class member [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_p.h(31,7): message : see declaration of 'QTaskbarControlPrivate::progressVisible' [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_win.cpp(72,67): warning C4458: declaration of 'progress' hides class member [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_p.h(32,9): message : see declaration of 'QTaskbarControlPrivate::progress' [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_win.cpp(83,42): warning C4458: declaration of 'counterVisible' hides class member [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_p.h(33,7): message : see declaration of 'QTaskbarControlPrivate::counterVisible' [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_win.cpp(83,62): warning C4458: declaration of 'counter' hides class member [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]
D:\a\crow-translate\crow-translate\src\third-party\qtaskbarcontrol\qtaskbarcontrol_p.h(34,6): message : see declaration of 'QTaskbarControlPrivate::counter' [D:\a\crow-translate\crow-translate\build\src\third-party\qtaskbarcontrol\QTaskbarControl.vcxproj]

I renamed function parameters progressVisible and counterVisible to visible and counter to value.

@Skycoder42 Skycoder42 merged commit 56a0aea into Skycoder42:master Oct 11, 2020
@Shatur Shatur deleted the fix-member-overwriting branch October 11, 2020 10:46
@Shatur
Copy link
Contributor Author

Shatur commented Oct 12, 2020

Would you kindly to draft a new minor release with this change? I use FetchContent in CMake and it would be nice to point stable release instead of specific branch or commit.

@Shatur Shatur mentioned this pull request Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants