audio/mpd: Updated for version 0.23.17 #13788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverse dependencies - audio/mpd
|
✅ sbolint - audio/mpd ✅ |
Member
|
@sbo-bot: build audio/mpd |
buildpkg i586 audio/mpdSnipped Build FailureDetails |
buildpkg x86_64 audio/mpdSnipped Build FailureDetails |
Collaborator
|
Seems we patched out the yajl suffix in the package config: And it looks like mpd changed where it looks in this release: might need to patch that back in |
Collaborator
|
Or the 0.24.x branch wrote out the yajl dependency: |
Contributor
Author
|
What's with the hints that generate additional dependencies? As far as hard requirements go, mpd has only REQUIRES=fmt and fmt has REQUIRES="". Therefore an mpt build should only be dragging in fmt as a requirement - nothing else. Yet from the failure report, many suggestions from the README are also dragged in as requirements. It is unclear how it is decided which ones end up being required - just that someone's hints are used. Now one of these arbitrarily chosen requirements is causing build failure for mpd. Somehow that doesn't seem right. |
Collaborator
We typically test with all the optional dependencies - those that are listed in the README as optional. Since that's a manual process, they can sometimes get out of sync over time. If I'm doing the reviews, I'll usually try to check and sync the hints when I approve submissions. I synced the hints for mpd earlier to the latest from the readme on master. They'll be used when the build is next triggered. yajl is a reverse dependency for about 20 packages - so for someone building with sbopkg on the target host etc, there is some chance that yajl will already be installed: https://slackbuilds.org/advsearch.php?q=yajl&stype=revdep, failing the build. If you don't want to support yajl, we should remove it from the readme and force disable it if that is possible. |
Member
0.24.x need newer GCC :( |
Member
|
@cwilling perhaps can you try to replace yajl with nlohmann_json since it is also your script? |
Collaborator
|
It might be simplest to just revert that commit I referenced: After unpacking the tarball in the slackbuild, apply with I tried it here to check and it builds: I don't use mpd, but you should be able to check locally if you have yajl installed and then build it. |
Contributor
Author
|
@sbo-bot: build audio/mpd |
buildpkg i586 audio/mpdSnipped Build LogDetails |
sbopkglint i586 audio/mpd |
buildpkg x86_64 audio/mpdSnipped Build LogDetails |
sbopkglint x86_64 audio/mpd |
Member
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version update enables building with recent fmt update to 12.1.0