Skip to content

Bug fix: Older code relied on the exception #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayaramcs merged 1 commit into from
Dec 19, 2025
Merged

Bug fix: Older code relied on the exception #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions bindings/java/src/org/sleuthkit/datamodel/HostAddressManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,11 @@ private HostAddress newHostAddress(HostAddress.HostAddressType type, String addr
}

String normalizedAddress = getNormalizedAddress(address);
// This prevents orphaned objects and ensures we return the existing valid object.
Optional<HostAddress> existingAddr = getHostAddress(addressType, normalizedAddress, connection);
if (existingAddr.isPresent()) {
return existingAddr.get();
}
try {

// TODO: need to get the correct parent obj id.
Expand All @@ -220,17 +225,8 @@ private HostAddress newHostAddress(HostAddress.HostAddressType type, String addr

long objId = db.addObject(parentObjId, objTypeId, connection);

/*
* A conflict clause is used improve performance related to
* exception handling in the database.
*/
String hostAddressInsertSQL;
if (db.getDatabaseType() == TskData.DbType.POSTGRESQL) {
hostAddressInsertSQL = "INSERT INTO tsk_host_addresses(id, address_type, address) VALUES (?, ?, ?) ON CONFLICT DO NOTHING"; //NON-NLS
} else {
hostAddressInsertSQL = "INSERT OR IGNORE INTO tsk_host_addresses(id, address_type, address) VALUES (?, ?, ?)"; //NON-NLS
}

String hostAddressInsertSQL = "INSERT INTO tsk_host_addresses(id, address_type, address) VALUES (?, ?, ?) "; //NON-NLS

PreparedStatement preparedStatement = connection.getPreparedStatement(hostAddressInsertSQL, Statement.RETURN_GENERATED_KEYS);

preparedStatement.clearParameters();
Expand Down