Skip to content

Conversation

@elainethale
Copy link
Contributor

Fixes #22
Fixes #23
Fixes #24
Fixes #28

And also generalizes get_short_name considerably.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #29 (8e8d121) into main (3d54942) will increase coverage by 0.11%.
The diff coverage is 87.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   73.78%   73.90%   +0.11%     
==========================================
  Files          16       18       +2     
  Lines        1259     1372     +113     
==========================================
+ Hits          929     1014      +85     
- Misses        330      358      +28     
Flag Coverage Δ
unit 73.90% <87.73%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
layerstack/args.py 53.37% <16.66%> (-4.78%) ⬇️
layerstack/layer.py 70.75% <50.00%> (+0.11%) ⬆️
layerstack/stack.py 69.32% <66.66%> (+0.09%) ⬆️
layerstack/tests/__init__.py 93.33% <90.90%> (-6.67%) ⬇️
...sts/layer_library/test_kwarg_name_clashes/layer.py 100.00% <100.00%> (ø)
...sts/layer_library/test_kwargs_with_dashes/layer.py 100.00% <100.00%> (ø)
layerstack/tests/test_layer.py 91.25% <100.00%> (+0.11%) ⬆️
layerstack/tests/test_layerbase.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d54942...8e8d121. Read the comment docs.

@elainethale elainethale merged commit d8c137d into main Aug 5, 2021
@elainethale elainethale deleted the eh/basic_fixes branch August 5, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants